Skip to content

build: Enable TypeScript type checking #7680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camdecoster wants to merge 7 commits into
base: master
Choose a base branch
from
Open

build: Enable TypeScript type checking #7680

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4011faa
Linting/formatting
camdecoster Jan 2, 2026
d4425fc
Initial TS set up
camdecoster Dec 30, 2025
71fc31c
Convert a few small files to TS
camdecoster Jan 2, 2026
3c905c0
Update requires to handle esbuild ESM/CJS interoperability
camdecoster Jan 2, 2026
bbc1059
Use ts-node for scripts using TS that run outside of esbuild
camdecoster Jan 2, 2026
116bf33
Run test script with ts-node
camdecoster Jan 2, 2026
2439dad
Merge remote-tracking branch 'origin/master' into cam/7678/enable-typ…
camdecoster Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update requires to handle esbuild ESM/CJS interoperability
  • Loading branch information
@camdecoster
camdecoster committed Jan 2, 2026
commit 3c905c0ea9598316dd23fa5566d43365dcf2cb1f
2 changes: 1 addition & 1 deletion src/components/colorscale/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

var colorbarAttrs = require('../colorbar/attributes');
var counterRegex = require('../../lib/regex').counter;
var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;

var palettes = require('./scales.js').scales;
var paletteStr = sortObjectKeys(palettes);
Expand Down
4 changes: 2 additions & 2 deletions src/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ lib.roundUp = searchModule.roundUp;
lib.sort = searchModule.sort;
lib.findIndexOfMin = searchModule.findIndexOfMin;

lib.sortObjectKeys = require('./sort_object_keys');
lib.sortObjectKeys = require('./sort_object_keys').default;

var statsModule = require('./stats');
lib.aggNums = statsModule.aggNums;
Expand Down Expand Up @@ -206,7 +206,7 @@ lib.pushUnique = require('./push_unique');

lib.increment = require('./increment');

lib.cleanNumber = require('./clean_number');
lib.cleanNumber = require('./clean_number').default;

lib.ensureNumber = function ensureNumber(v) {
if (!isNumeric(v)) return BADNUM;
Expand Down
2 changes: 1 addition & 1 deletion src/plots/geo/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var domainAttrs = require('../domain').attributes;
var dash = require('../../components/drawing/attributes').dash;
var constants = require('./constants');
var overrideAll = require('../../plot_api/edit_types').overrideAll;
var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;
Copy link
Copy Markdown
Contributor

@emilykl emilykl Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camdecoster Is it worth considering moving away from default exports entirely as part of this transition?

Copy link
Copy Markdown
Contributor Author

@camdecoster camdecoster Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only matters when one mixes CJS and ESM. That said, I don't think that we can avoid that for a long time. I suppose we could make just pick a direction to go and standardize. I could go either way, but the esbuild docs make it clear that they don't like default exports.


var geoAxesAttrs = {
range: {
Expand Down
2 changes: 1 addition & 1 deletion src/plots/map/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;
var arcgisSatHybrid = require('./styles/arcgis-sat-hybrid'); // https://raw.githubusercontent.com/go2garret/maps/v1.0.0/LICENSE
var arcgisSat = require('./styles/arcgis-sat');

Expand Down
2 changes: 1 addition & 1 deletion src/plots/mapbox/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;

var requiredVersion = '1.13.4';

Expand Down
2 changes: 1 addition & 1 deletion src/traces/scatter3d/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var DASHES = require('../../constants/gl3d_dashes');
var MARKER_SYMBOLS = require('../../constants/gl3d_markers');
var extendFlat = require('../../lib/extend').extendFlat;
var overrideAll = require('../../plot_api/edit_types').overrideAll;
var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;

var scatterLineAttrs = scatterAttrs.line;
var scatterMarkerAttrs = scatterAttrs.marker;
Expand Down
2 changes: 1 addition & 1 deletion src/traces/scattergl/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var scatterAttrs = require('../scatter/attributes');
var axisHoverFormat = require('../../plots/cartesian/axis_format_attributes').axisHoverFormat;
var colorScaleAttrs = require('../../components/colorscale/attributes');

var sortObjectKeys = require('../../lib/sort_object_keys');
var sortObjectKeys = require('../../lib/sort_object_keys').default;
var extendFlat = require('../../lib/extend').extendFlat;
var overrideAll = require('../../plot_api/edit_types').overrideAll;
var DASHES = require('./constants').DASHES;
Expand Down
Loading