Skip to content

fix: ggplotly() regressions #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpsievert wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: ggplotly() regressions #2472

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d22f26
Fix #2458: remove warnings for valid layout attributes
cpsievert Jan 20, 2026
6a47185
Fix #2420: ggplotly legend now uses scale labels
cpsievert Jan 20, 2026
4be6198
Fix #2462: dynamicTicks now works with grouped geom_line
cpsievert Jan 20, 2026
0581ef5
Fix #2446: Date class preserved in colorbar trace
cpsievert Jan 20, 2026
0dfe79d
Add tests for bug fixes and update NEWS
cpsievert Jan 20, 2026
23efe22
Merge branch 'master' into fix-ggplotly-medium-issues
cpsievert Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix #2462: dynamicTicks now works with grouped geom_line 
NA values in trace data (e.g., from geom_line gaps between groups) now
correctly remain as NA when mapping categorical data back to ticktext
labels. Previously, which.min() on NA values returned an empty vector
which caused an indexing error.

Fixes #2462

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
  • Loading branch information
@cpsievert @claude
cpsievert and claude committed Jan 20, 2026
commit 4be6198deee45598b1259f2ffecfdf9924a97b04
4 changes: 3 additions & 1 deletion R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,10 +843,12 @@ gg2list <- function(p, width = NULL, height = NULL,

# inverse transform categorical data based on tickvals/ticktext
if (isDiscreteType) {
traces <- lapply(traces, function(tr) {
traces <- lapply(traces, function(tr) {
# map x/y trace data back to the 'closest' ticktext label
# http://r.789695.n4.nabble.com/check-for-nearest-value-in-a-vector-td4369339.html
tr[[xy]]<- vapply(tr[[xy]], function(val) {
# NA values (e.g., geom_line gaps) should remain NA
if (is.na(val)) return(NA_character_)
with(axisObj, ticktext[[which.min(abs(tickvals - val))]])
}, character(1))
tr
Expand Down