Skip to content

Add candlestick support #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moutikabdessabour wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add candlestick support #2053

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9fb273d
Closes #2016. Added support for `geom_candlestick`.
moutikabdessabour Oct 23, 2021
35b95a8
Added test to showcase the functionality.
moutikabdessabour Oct 23, 2021
e18b3fc
Added test to showcase the functionality.
moutikabdessabour Oct 23, 2021
46203d5
Added test to showcase the functionality.
moutikabdessabour Oct 23, 2021
68466fc
Modified the step test as the new feauture kinda broke the tests
moutikabdessabour Oct 31, 2021
47cc776
Update NEWS.md
moutikabdessabour Nov 2, 2021
505b882
Update tests
moutikabdessabour Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update NEWS.md 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
  • Loading branch information
@moutikabdessabour @cpsievert
moutikabdessabour and cpsievert authored Nov 2, 2021
commit 47cc776d0a05fb74dfd6de709ef7979ded9e469f
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Improvements

* `ggplotly()` now supports `geom_candlestick`. (#2053)
* `ggplotly()` now supports `tidyquant::geom_candlestick()`. (#2053)
* `ggplotly()` does not issue warnings with `options(warnPartialMatchArgs = TRUE)` any longer. (#2046, @bersbersbers)

# 4.10.0
Expand Down