Skip to content

Add kaleido() for static image exporting #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 42 commits into from
Jul 14, 2021
Merged

Add kaleido() for static image exporting #1971

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
367b21a
wip implement kaleido() for image exporting
cpsievert Jul 2, 2021
cae8919
Fix sf on mac
cpsievert Jul 2, 2021
1c592ae
Try again
cpsievert Jul 2, 2021
1fcd709
sf is such a headache
cpsievert Jul 2, 2021
9f1c8fb
cleanup print method
cpsievert Jul 2, 2021
22ea199
attempt to 'fix' conda install
cpsievert Jul 2, 2021
d88de96
attempt to 'fix' conda install
cpsievert Jul 2, 2021
88b1d3f
attempt to 'fix' conda install
cpsievert Jul 2, 2021
40bd2b1
attempt to 'fix' conda install
cpsievert Jul 2, 2021
053beb7
attempt to 'fix' conda install
cpsievert Jul 2, 2021
093c771
attempt to 'fix' conda install
cpsievert Jul 2, 2021
bf029d3
attempt to 'fix' conda install
cpsievert Jul 2, 2021
525eb1e
give up on conda
cpsievert Jul 2, 2021
a43ceed
attempt to 'fix' conda install
cpsievert Jul 2, 2021
bef0e18
bring back sf
cpsievert Jul 2, 2021
8c39425
install kaleido in reticulate env
cpsievert Jul 2, 2021
0d7dfc0
sffff
cpsievert Jul 2, 2021
260c6e6
ignore sf again
cpsievert Jul 2, 2021
d26fb06
fix
cpsievert Jul 2, 2021
5a12147
debug
cpsievert Jul 2, 2021
e3b565e
Use import() for better namespacing
cpsievert Jul 2, 2021
73caad6
:fingers-crossed:
cpsievert Jul 2, 2021
52a4674
use a special conda env
cpsievert Jul 2, 2021
df8d6cd
try installing miniconda first
cpsievert Jul 2, 2021
705235f
use miniconda
cpsievert Jul 2, 2021
d101fcc
go back to r-reticulate
cpsievert Jul 2, 2021
9519cab
debug
cpsievert Jul 2, 2021
03c9f42
progress
cpsievert Jul 2, 2021
779c3f3
increase max failures
cpsievert Jul 2, 2021
edeed4b
new snaps
cpsievert Jul 2, 2021
95dbd87
missed one
cpsievert Jul 2, 2021
11ea89a
install
cpsievert Jul 2, 2021
79f646b
accept new baselines
cpsievert Jul 14, 2021
ee06116
fix install
cpsievert Jul 14, 2021
9bb78ec
update news
cpsievert Jul 14, 2021
5c948f4
add installation section
cpsievert Jul 14, 2021
0a37c6a
update news
cpsievert Jul 14, 2021
b8eb4bd
add back sf
cpsievert Jul 14, 2021
6963800
don't upgrade
cpsievert Jul 14, 2021
225be14
don't upgrade
cpsievert Jul 14, 2021
2839004
approve new visual baselines
cpsievert Jul 14, 2021
a928096
pak isn't ready for prod
cpsievert Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix install
  • Loading branch information
@cpsievert
cpsievert committed Jul 14, 2021
commit ee06116777a7c2a0418211cf2bfaecdeb9627857
4 changes: 2 additions & 2 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ jobs:
shell: Rscript {0}

- name: Install package
run: R CMD install .
shell: bash
run: pak::pak()
shell: Rscript {0}

# Run test() before R CMD check since, for some reason, rcmdcheck::rcmdcheck() skips vdiffr tests
- name: Run Tests
Expand Down