Skip to content

Preserve milliseconds with dynamicTicks #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 5 commits into from
Dec 8, 2020
+16 −2
Merged

Preserve milliseconds with dynamicTicks #1871

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11908ff
Fix #1870 by explicitly including milliseconds when converting to JSON
Oct 26, 2020
83c0ee7
Added visual test for #1870
Oct 26, 2020
6a8a686
Fix POSIXt format for plotly JSON
FlukeAndFeather Oct 26, 2020
2569d03
Fixing time format in test re: #1871
Oct 29, 2020
c81d657
Update test image for line-milliseconds.svg
Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix POSIXt format for plotly JSON 
According to plotly documentation (https://plotly.com/chart-studio-help/date-format-and-time-series/): "Chart Studio’s date format is 'yyyy-mm-dd HH:MM:SS.ssssss'.", so time_format in jsonlite::toJSON() changed to match.
  • Loading branch information
@FlukeAndFeather
FlukeAndFeather authored Oct 26, 2020
commit 6a8a6865ef88061c8c4331773d7ede0c50770961
2 changes: 1 addition & 1 deletion R/utils.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,7 +1022,7 @@ try_file <- function(f, what) {
to_JSON <- function(x, ...) {
jsonlite::toJSON(x, digits = 50, auto_unbox = TRUE, force = TRUE,
null = "null", na = "null",
time_format = "%Y-%m-%dT%H:%M:%OS3%z", ...)
time_format = "%Y-%m-%d %H:%M:%OS6", ...)
}

# preferred defaults for toJSON mapping
Expand Down