Skip to content

Get ggplotly() playing nicely with thematic #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 7 commits into from
Jun 25, 2020
Merged

Get ggplotly() playing nicely with thematic #1801

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85818b1
Pull plotly's custom ggplot_build into a function and hook into thema…
cpsievert Jun 23, 2020
9c864d6
add thematic to suggests and use it only when loaded
cpsievert Jun 25, 2020
6113185
update shinytest tests
cpsievert Jun 25, 2020
9114b8a
Go back to the assign() based approach
cpsievert Jun 25, 2020
c5a8a2f
bust cache
cpsievert Jun 25, 2020
deaa381
CRAN version of crosstalk
cpsievert Jun 25, 2020
af9a229
add visual tests
cpsievert Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Go back to the assign() based approach
  • Loading branch information
@cpsievert
cpsievert committed Jun 25, 2020
commit 9114b8ad82172a368bf5ec3f83b5c7b52b4121b1
21 changes: 12 additions & 9 deletions R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,13 @@ gg2list <- function(p, width = NULL, height = NULL,
suppressMessages(dplyr::left_join(x, y))
}, data, nestedKeys, layers)

# return all the objects in this environmet
mget(ls(environment()), inherits = FALSE)
structure(
list(
data = data, layout = layout, plot = plot,
env = environment()
),
class = "ggplot_built"
)
}

# Allow thematic to add new defaults to the plot object based on it's theme
Expand All @@ -431,15 +436,13 @@ gg2list <- function(p, width = NULL, height = NULL,
ggplotly_build(p)
}

# ggplotly_build() returns list of objects...make them known to gg2list() env

env <- environment()
for (var in names(built)) {
assign(var, built[[var]], envir = env)
# Assign all the objects available to ggplotly_build() to this functions environment
built_env <- built$env
envir <- environment()
for (var in ls(built_env)) {
assign(var, built_env[[var]], envir = envir)
}
Comment thread
cpsievert marked this conversation as resolved.



# initiate plotly.js layout with some plot-wide theming stuff
theme <- ggfun("plot_theme")(plot)
elements <- names(which(sapply(theme, inherits, "element")))
Expand Down