Fix caffeine config#10398
Merged
Merged
Conversation
8 tasks
Member
Hum, I wonder if it would be possible to somehow report the configuration error. Maybe logging a warn or even throwing an error. What do you think? |
a4d69dd to
4eec752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, please have a look at how these configs get parsed here.
Now, this is what I fixed:
weak-keyswas defined twice. No need.maximum-sizewas missing in the config.weak-valueswas missing as well. Also eitherweak-valuesorsoft-valuesshould be set totrueat a certain moment, not both at the same time, because if the "value strength" was set once, it can't be set to another value anymore, therefore setting both results in undertimed behaviour (we don't know which was set first). See the caffeine implementation: https://github.com/ben-manes/caffeine/blob/v3.1.1/caffeine/src/main/java/com/github/benmanes/caffeine/cache/Caffeine.java#L555-L556and
https://github.com/ben-manes/caffeine/blob/v3.1.1/caffeine/src/main/java/com/github/benmanes/caffeine/cache/Caffeine.java#L591-L592
Adding this configs does not change the behaviour, so we can backport to 2.8.x