Skip to content

Fleshing out parseArgs to support withValue and Multiples options #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joesepi merged 8 commits into from
Oct 4, 2021
Merged

Fleshing out parseArgs to support withValue and Multiples options #9

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4486551
feat(parseArgs): set positionals and handle withValue with multiples …
Sep 24, 2021
5db0c6e
Revert "feat(parseArgs): set positionals and handle withValue with mu…
JessNah Sep 24, 2021
1342edf
feat(parseArgs): set positionals and handle withValue with multiples
JessNah Sep 24, 2021
8f29353
chore: add more comments
Sep 28, 2021
8892a2b
chore(parse-args): resolve type checking on withValue to handle false…
Sep 28, 2021
71e0c0a
chore(parseargs): fix formatting on line 10
JessNah Oct 2, 2021
c58fc4d
chore(parseargs): optimize line 48 following suggestion
JessNah Oct 2, 2021
a44de49
chore(parseargs): optimize lines 61 and 66 following suggestion
Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add more comments
  • Loading branch information
Jessica Nahulan authored and Jessica Nahulan committed Sep 28, 2021
commit 8f2935360d8bb73b61ea11c995b7784ec05d3c98
11 changes: 7 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,26 @@ const parseArgs = (
arg = arg.replace(/^-+/, '')

if (arg.includes('=')) {
//withValue equals(=) case
const argParts = arg.split('=')

result.args[argParts[0]] = true
//If withValue option isn't specified, set value as undefined
//If withValue option is specified, take 2nd part after '=' as value, else set value as undefined
const val = options.withValue && options.withValue.includes(argParts[0]) ? argParts[1] : undefined
//Append value to previous arg values array for case of multiples option, else add to empty array
result.values[argParts[0]] = [...(options.multiples && options.multiples.includes(argParts[0]) && result.values[argParts[0]] ? result.values[argParts[0]] : []), val]
Comment thread
JessNah marked this conversation as resolved.
Outdated
} else if (pos + 1 < argv.length) {
} else if (pos + 1 < argv.length && !argv[pos+1].startsWith('-')) {
//withValue option should also support setting values when '=' isn't used
//ie. both --foo=bar and --foo bar should work
//ie. both --foo=b and --foo b should work

result.args[arg] = true
//If withValue option isn't specified, set value as undefined
//If withValue option is specified, take next position arguement as value and then increment pos so that we don't re-evaluate that arg, else set value as undefined
//ie. --foo b --bar c, after setting b as the value for foo, evaluate --bar next and skip 'b'
const val = options.withValue && options.withValue.includes(arg) ? argv[++pos] : undefined
//Append value to previous arg values array for case of multiples option, else add to empty array
result.values[arg] = [...(options.multiples && options.multiples.includes(arg) && result.values[arg] ? result.values[arg] : []), val]
Comment thread
ljharb marked this conversation as resolved.
Outdated
} else {
//cases when an arg is specified without a value, example '--foo --bar' <- 'foo' and 'bar' args should be set to true and have value as undefined
result.args[arg] = true
//Append undefined to previous arg values array for case of multiples option, else add to empty array
result.values[arg] = [...(options.multiples && options.multiples.includes(arg) && result.values[arg] ? result.values[arg] : []), undefined]
Comment thread
ljharb marked this conversation as resolved.
Outdated
Expand Down