Skip to content

feat: add default option parameter #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eomm merged 12 commits into from
Oct 8, 2022
Merged

feat: add default option parameter #142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4313c8a
feat: add defaultValue option parameter
Eomm Aug 13, 2022
8a7a813
fix: removed default values from tokens
Eomm Aug 14, 2022
d94289a
chore: moved utility function
Eomm Aug 16, 2022
df855e0
feat: manage defaultValue array
Eomm Aug 16, 2022
d5759a0
docs: fix option type
Eomm Aug 16, 2022
15d988a
fix: multiple option value instead of presence
Eomm Aug 16, 2022
50f2b25
docs: add example
Eomm Aug 17, 2022
ea92d4e
fix: restore multiple boolean check when needed
Eomm Aug 17, 2022
f9e72da
fix: feedback
Eomm Aug 20, 2022
dd078a7
chore: rename defaultValue option to default
Eomm Aug 20, 2022
7f68c46
fix: test description
Eomm Sep 2, 2022
b2f6a44
chore: update after merge into node.js core
Eomm Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: multiple option value instead of presence
  • Loading branch information
@Eomm
Eomm committed Oct 7, 2022
commit 15d988ae2f1862d09b8b51412353fbca153cce4e
14 changes: 6 additions & 8 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,20 +328,18 @@ const parseArgs = (config = kEmptyObject) => {
}
}

const hasMultipleFlag = ObjectHasOwn(optionConfig, 'multiple');
if (hasMultipleFlag) {
validateBoolean(optionConfig.multiple, `options.${longOption}.multiple`);
}
validateBoolean(ObjectHasOwn(optionConfig, 'multiple'), `options.${longOption}.multiple`);

if (ObjectHasOwn(optionConfig, 'defaultValue')) {
const defaultValue = objectGetOwn(optionConfig, 'defaultValue');
if (optionType === 'string' && !hasMultipleFlag) {
const multipleOption = objectGetOwn(optionConfig, 'multiple');
if (optionType === 'string' && !multipleOption) {
validateString(defaultValue, `options.${longOption}.defaultValue`);
} else if (optionType === 'string' && hasMultipleFlag) {
} else if (optionType === 'string' && multipleOption) {
validateStringArray(defaultValue, `options.${longOption}.defaultValue`);
} else if (optionType === 'boolean' && !hasMultipleFlag) {
} else if (optionType === 'boolean' && !multipleOption) {
validateBoolean(defaultValue, `options.${longOption}.defaultValue`);
} else if (optionType === 'boolean' && hasMultipleFlag) {
} else if (optionType === 'boolean' && multipleOption) {
validateBooleanArray(defaultValue, `options.${longOption}.defaultValue`);
}
}
Expand Down
11 changes: 11 additions & 0 deletions test/default-values.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,14 @@ test('proto as default value must be ignored', (t) => {
t.deepEqual(result, expected);
t.end();
});


test('multiple as false should not expect an array', (t) => {
Comment thread
shadowspawn marked this conversation as resolved.
Outdated
const args = [];
const options = { alpha: { type: 'string', multiple: false, defaultValue: 42 } };
t.throws(() => {
parseArgs({ args, options });
}, /alpha\.defaultValue must be String/
);
t.end();
});