Add securityGroup and securityGroupIngress management to amazon provider#99
Merged
Conversation
Contributor
|
Thanks @zbal ... could you look into adding tests for this feature? |
Contributor
Author
|
Sure, I can prepare the aws API responses in the fixture / amazon and look into integrating this is the other tests. I can't find any example from the keys feature, is it something missing as well? |
Contributor
|
@zbal Yes, tests might be missing for that as well :-/ |
Contributor
Author
|
Finally passed TravisCI ! Added:
BTW I don't get how to run the tests locally, it always fails with |
Contributor
|
@zbal Nice! Will look into merging this now. |
Contributor
Author
|
Great! Looking forward to it :) BTW - how to run the tests locally? I'd like to avoid having to push 10 commits just to fix some typo when I can run the tests locally |
indexzero
added a commit
that referenced
this pull request
Apr 22, 2013
Contributor
|
Just run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following keys.js approach, add securityGroup + ingress rules to amazon provider.
Cheers.