adding first tests

pkgcloud · morsh · Dec 12, 2016 · Dec 13, 2016 · Dec 13, 2016 · Dec 13, 2016
commit 1eb444f7f9c1679bef1b17bd6422c65e34fddbc2
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -35,6 +35,35 @@
       "cwd": "${workspaceRoot}",
       "stopOnEntry": true
     },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Test Azure V2 Server",
+      "program": "${workspaceRoot}//test//azure-v2//compute//client//test-getServers.js",
+      "cwd": "${workspaceRoot}",
+      "stopOnEntry": true,
+      "env": {
+        "MOCK": "on"
+      }
+    },
+		{
+			// Name of configuration; appears in the launch configuration drop down menu.
+			"name": "Run mocha",
+			// Type of configuration. Possible values: "node", "mono".
+			"type": "node",
+			// Workspace relative or absolute path to the program.
+			"program": "${workspaceRoot}//node_modules//mocha//bin//_mocha",
+			// Automatically stop program after launch.
+			"stopOnEntry": false,
+			// Command line arguments passed to the program.
+			"args": ["${workspaceRoot}//test//azure-v2//compute//client//test-getServers.js"],
+			// Workspace relative or absolute path to the working directory of the program being debugged. Default is the current workspace.
+			"cwd": "${workspaceRoot}",
+			// Workspace relative or absolute path to the runtime executable to be used. Default is the runtime executable on the PATH.
+			"runtimeExecutable": null,
+			// Environment variables passed to the program.
+			"env": { "MOCK": "on" }
+		},
     {
       "type": "node",
       "request": "attach",

diff --git a/examples/compute/azure-v2.js b/examples/compute/azure-v2.js
@@ -6,15 +6,15 @@ var options;
 // Create a pkgcloud compute instance
 //
 options = {
-  resourceGroup: '{resourceGroup}',
   provider: 'azure-v2',
-  storageAccount: '{storeName}',
-  storageAccessKey: '{storeKey}',
-  subscriptionId: '{subscriptionId}',
-  spClientId: '{spClientId}',
-  spSecret: '{spSecret}',
-  spDomain: '{spDomain}',
-  spSubscriptionId: '{spSubscriptionId}'
+  subscriptionId: "{subscriptionId}",  
+  resourceGroup: "{resourceGroup}",
+
+  servicePrincipal: {
+    clientId: "{spClientId}",
+    secret: "{spSecret}",
+    domain: "{spDomain}"
+  }
 };
 client = pkgcloud.compute.createClient(options);
 

diff --git a/lib/pkgcloud/azure-v2/compute/client/servers.js b/lib/pkgcloud/azure-v2/compute/client/servers.js
@@ -138,72 +138,60 @@ function destroyServer(server, callback) {
   });
 }
 
-//
-// ### function stopServer(server, callback)
-// #### @server {Server|String} Server id or a server
-// #### @callback {Function} f(err, serverId).
-//
-// Destroy a server in Azure.
-//
+/**
+ * Stop a server in Azure.
+ * @param {Server|string} server Server id or a server
+ * @param {function} callback cb(err, serverId).
+ */
 function stopServer(server, callback) {
   var self = this;
   var serverId = server instanceof self.models.Server ? server.id : server;
 
-  console.log('Stopping', serverId, '...');
-  return callback(new Error('not implemented yet'));
-  // azureApi.stopServer(this, serverId, function (err) {
-  //   return !err
-  //     ? callback(null, { ok: serverId })
-  //     : callback(err);
-  // });
-}
+  self.login(err => {
+
+    if (err) {
+      return callback(err);
+    }
 
-//
-// ### function createHostedService(serviceName, callback)
-// #### @serviceName {String} name of the Hosted Service
-// #### @callback {Function} f(err, serverId).
-//
-// Creates a Hosted Service in Azure.
-//
-function createHostedService(serviceName, callback) {
-  console.log('createing hosted service', serviceName, '...');
-  return callback(new Error('not implemented yet'));
-  // azureApi.createHostedService(this, serviceName, function (err, res) {
-  //   return !err
-  //     ? callback(null, res)
-  //     : callback(err);
-  // });
+    var client = new ComputeManagementClient(self.azure.credentials, self.config.subscriptionId);
+    client.virtualMachines.powerOff(self.config.resourceGroup, serverId, (err) => {
+      return err
+        ? callback(err)
+        : callback(null, serverId);
+    });
+  });
 }
 
-//
-// ### function rebootServer (server, options, callback)
-// #### @server   {Server|String} The server to reboot
-// #### @callback {Function} f(err, server).
-//
-// Reboots a server
-//
+/**
+ * Restart a server in Azure.
+ * @param {Server|string} server Server id or a server
+ * @param {function} callback cb(err, serverId).
+ */
 function rebootServer(server, callback) {
   var self = this;
   var serverId = server instanceof self.models.Server ? server.id : server;
 
-  console.log('rebotting server', serverId, '...');
-  return callback(new Error('not implemented yet'));
-  // azureApi.rebootServer(this, serverId, function (err) {
-  //   return !err
-  //     ? callback(null, { ok: serverId })
-  //     : callback(err);
-  // });
+  self.login(err => {
+
+    if (err) {
+      return callback(err);
+    }
+
+    var client = new ComputeManagementClient(self.azure.credentials, self.config.subscriptionId);
+    client.virtualMachines.restart(self.config.resourceGroup, serverId, (err) => {
+      return err
+        ? callback(err)
+        : callback(null, serverId);
+    });
+  });
 }
 
-//
-// ### function renameServer(server, name, callback)
-// #### @server {Server|String} Server id or a server
-// #### @name   {String} New name to apply to the server
-// #### @callback {Function} f(err, server).
-//
-// Renames a server
-//
-function renameServer(server, name, callback) {
+/**
+ * Rename a server in Azure.
+ * @param {Server|string} server Server id or a server
+ * @param {function} callback cb(err, serverId).
+ */
+function renameServer(server, callback) {
   return errs.handle(
     errs.create({ message: 'Not supported by Azure.' }),
     callback
@@ -218,7 +206,6 @@ module.exports = {
   createServer,
   destroyServer,
   stopServer,
-  createHostedService,
   rebootServer,
   renameServer
 };
diff --git a/lib/pkgcloud/azure-v2/compute/server.js b/lib/pkgcloud/azure-v2/compute/server.js
@@ -16,7 +16,7 @@ var Server = exports.Server = function Server(client, details) {
 
 util.inherits(Server, base.Server);
 
-Server.prototype._setProperties = function (details, statuses) {
+Server.prototype._setProperties = function (details) {
 
   details = details || {};
   this.id = details.id || '';

diff --git a/package.json b/package.json
@@ -84,6 +84,7 @@
     "jshint": "~2.7.0",
     "mocha": "1.21.x",
     "mocha-lcov-reporter": "0.0.1",
+    "nock": "^9.0.2",
     "should": "4.0.x"
   },
   "main": "./lib/pkgcloud",

diff --git a/test/azure-v2/compute/client/test-getServers.js b/test/azure-v2/compute/client/test-getServers.js
@@ -0,0 +1,63 @@
+//TODO: Make this a vows test
+
+var mockRequests = require('../../mock-requests');
+var helpers = require('../../../helpers');
+var should = require('should');
+var mock = !!process.env.MOCK;
+
+// client.getServer('azure-vm-server', function (err, result) {
+//   if (err) {
+//     console.error(err);
+//   } else {
+//     console.dir(result);
+//   }
+// });
+
+// client.getServers(function (err, result) {
+//   if (err) {
+//     console.error(err);
+//   } else {
+//     console.dir(result);
+//   }
+// });
+
+describe('pkgcloud/amazon/groups', function () {
+
+  var client;
+
+  before(function (done) {
+    debugger;
+    client = helpers.createClient('azure-v2', 'compute');
+
+    if (!mock) {
+      return done();
+    }
+
+    mockRequests.prepare();
+  });
+
+  it('add SecurityGroup should succeed', function(done) {
+
+    debugger;
+    client.getServer('azure-vm-server', (err, server) => {
+      should.not.exist(err);
+      should.exist(server)
+      server.status.should.equal('RUNNING');
+    });
+
+  });
+
+  after(function(done) {
+    if (!mock) {
+      return done();
+    }
+
+    //server.close(done);
+  });
+});
+
+
+
+
+
+
diff --git a/test/azure-v2/mock-requests.js b/test/azure-v2/mock-requests.js
@@ -0,0 +1,40 @@
+var path = require('path');
+var nock = require('nock');
+var helpers = require('../helpers');
+
+const azureAuthUri = 'https://login.microsoftonline.com';
+const azureManagementUri = 'https://management.azure.com';
+const requestId = 'b67cc525-ecc5-4661-8fd6-fb3e57d724f5';
+const apiVersion = '2016-03-30';
+
+function loadFixture(name) {
+  return helpers.loadFixture(path.join('azure-v2', name));
+}
+
+function prepare() {
+
+  var config = helpers.loadConfig('azure-v2');
+  var sp = config.servicePrincipal;
+
+
+  // Nock authentication requests
+  nock(`${azureAuthUri}`)
+    .post(`/${sp.domain}/oauth2/token?api-version=1.0`)
+    .reply(200, loadFixture('authentication-certificate.json'));
+
+  // Subscriptions
+  nock(`${azureManagementUri}`)
+    .get('/subscriptions?api-version=2015-11-01')
+    .reply(200, loadFixture('subscriptions.json'));
+
+  // Servers
+  nock(`${azureManagementUri}/subscriptions/${config.subscriptionId}/resourceGroups/${config.resourceGroup}/providers/Microsoft.Compute`)
+    .get(`/virtualMachines?api-version=${apiVersion}`)
+    .reply(200, loadFixture('servers.json'))
+    .get(`/virtualMachines/azure-vm-server?$expand=instanceView&api-version=${apiVersion}`)
+    .reply(200, loadFixture('server.json'))
+}
+
+module.exports = {
+  prepare
+};
diff --git a/test/configs/mock/azure-v2.json b/test/configs/mock/azure-v2.json
@@ -0,0 +1,9 @@
+{
+    "subscriptionId": "azure-account-subscription-id",
+    "resourceGroup": "resource-group",
+    "servicePrincipal": {
+        "clientId": "sp-client-id",
+        "secret": "sp-secret",
+        "domain": "sp-domain"
+    }
+}
diff --git a/test/fixtures/azure-v2/authentication-certificate.json b/test/fixtures/azure-v2/authentication-certificate.json
@@ -0,0 +1,9 @@
+{
+  "token_type":"Bearer",
+  "expires_in":"3600",
+  "ext_expires_in":"10800",
+  "expires_on":"1483452282",
+  "not_before":"1483448382",
+  "resource":"https://management.core.windows.net/",
+  "access_token":"XXXXXXXX"
+}