Fn arg check#212
Merged
Merged
Conversation
Turns out my tests were rather poor...
Member
Author
There was a problem hiding this comment.
Whoops, a missing )!
Contributor
+1 Also, I was thinking test-fns.pxi should probably have some tests around multi-arity and variable-arity fns i.e. that these argument count validations don't get triggered. wdyt? |
Passing an invalid number of args to a MultiArityFn should throw and error now which includes the name of the function.
Member
Author
|
I've added in some MultiArityFn and VariadicFn runtime exceptions. The messages are probably not the best atm and I had to touch a fair few files. I'm still not that happy with the tests either, but its something for now. |
Member
Author
|
@pmonks the false positives you mention are exactly what was wrong with my original tests. I've added an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
I wrote tests and some better checks a while ago, but it seems those tests were rather broken. See
tests-fns.pxi. Something like(is (thrown? ...))from clojure.test would be nice.This also ended up catching some things with extraneous args.