Skip to content

perf: optimize .child #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsumners merged 2 commits into from
Oct 2, 2025
Merged

perf: optimize .child #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f6b96
perf: optimize .child
ronag Sep 28, 2025
ca29c08
Update lib/proto.js
mcollina Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions lib/proto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ const {
asChindings,
asJson,
buildFormatters,
stringify
stringify,
noop
} = require('./tools')
const {
version
Expand Down Expand Up @@ -86,11 +87,32 @@ function child (bindings, options) {
if (!bindings) {
throw Error('missing bindings for child Pino')
}
options = options || {} // default options to empty object
const serializers = this[serializersSym]
const formatters = this[formattersSym]
const instance = Object.create(this)

// If an `options` object was not supplied, we can improve
// the performance of child creation by skipping
// the checks for set options and simply return
// a baseline instance.
if (options == null) {
Comment thread
mcollina marked this conversation as resolved.
if (instance[formattersSym].bindings !== resetChildingsFormatter) {
Comment thread
ronag marked this conversation as resolved.
instance[formattersSym] = buildFormatters(
formatters.level,
resetChildingsFormatter,
formatters.log
)
}

instance[chindingsSym] = asChindings(instance, bindings)

if (this.onChild !== noop) {
this.onChild(instance)
}
Comment thread
mcollina marked this conversation as resolved.

return instance
}

if (options.hasOwnProperty('serializers') === true) {
instance[serializersSym] = Object.create(null)

Expand Down Expand Up @@ -223,8 +245,6 @@ function write (_obj, msg, num) {
stream.write(streamWriteHook ? streamWriteHook(s) : s)
}

function noop () {}

function flush (cb) {
if (cb != null && typeof cb !== 'function') {
throw Error('callback must be a function')
Expand Down
4 changes: 2 additions & 2 deletions lib/tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,10 @@ function asChindings (instance, bindings) {

for (const key in bindings) {
value = bindings[key]
const valid = key !== 'level' &&
const valid = (key.length < 5 || (key !== 'level' &&
key !== 'serializers' &&
key !== 'formatters' &&
key !== 'customLevels' &&
key !== 'customLevels')) &&
Comment thread
mcollina marked this conversation as resolved.
bindings.hasOwnProperty(key) &&
value !== undefined
if (valid === true) {
Expand Down