Catching errors#89
Merged
Merged
Conversation
With no PMS sensor attached you cannot flip through the screens ( tapping the light sensor until you reach the PMS page will throw uncaught exception. Added exception to the three cases, in the same manner as the main page
Member
|
If you have the time/inclination, could you please rebase this so the tests can run? Sorry- Python 3.4 support was quietly dropped from GitHub Actions and left a lot of broken tests for me to find. |
Member
|
Tests be darned (they don't cover examples anyway), ran this locally and it's great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no PMS sensor attached you cannot flip through the screens ( tapping the light sensor until you reach the PMS page will throw uncaught exception.
Added exception to the three cases, in the same manner as the main page