TEst#1
Merged
Merged
Conversation
- fixed a few bugs - removed unnecessary files - renamed tests to xxxxTest.java so that surefire picks them up - made sure that resource files are not rewritten by tests
Making sure that tests in aa-prop run. They weren't running at all
Removing deprecated classes for biojava 4 release
The CLIs for most structure alignment algorithms derive from AbstractUserArgumentParser, but there wasn't a good mechanism to introduce new arguments, since all parameters are stored into a bean. Without refactoring everything, this makes the parameter specification a bit more consistent. The standard parameters are still stored in a StartupParameters bean, but this is extended by each class to store the class-specific parameters. Help strings are taken from a ConfigStrucAligParams subclass, which was previously only used for the GUI parameters. So the GUI and CLI parameter lists should now match. The procedure for adding a new CLI implementation is documented in AbstractUserArgumentParser. Methods converted to the new system: * Ce * CeCP * FatCat * SmithWaterman3D Other AbstractUserArgumentParser implementations downstream of BioJava will need to be updated to work with the new system.
printHelp() is now required for all UserArgumentProcessors (moved from it's previous location in StructureAlignment.) This allows -h, -help, and -version to be handled consistently in the argument parser rather than in each aligner. Also cleaned up some 'throw Exception/catch Exception' uses. Finally, slightly changed the behavior of boolean arguments. Valid values are nothing (determine value based on '-no' prefix), t/true, and f/false. Other options give errors rather than defaulting to false (the Boolean.parseBoolean() behavior).
Improvements to Structure alignment CLIs
- Don't print CE when -show3d is given
…r interface and is able to use the new GenbankSequenceParser
Adds accelerators (shortcuts, e.g. Ctrl-Q) for major menu items. Redefine mnemonics (e.g. Alt-F Q) to remove redundant mnemonics
-added 2 test cases to GenbankReaderTest
reason there is an increment added in GenericInsdcHeaderFormat which is responsible for this effect. Changing the increment to 0 patches the writer.
… not make sense at this stage.
GenbankReader patch for multiple sequences from single file
This changes the behaviour of Compound.getChainIDs() to only return the unique chain ids
The new resources already existed but they were not referenced to, now also removed the old org/biojava/bio resource files too
before it was first model only.
The bug must have been introduced in 4.0 because Structure.clone() now does full cloning of all models and I suppose before it wasn't. Introduced test for quat symmetry detection.
and throwing exception. Related to #111
pibizza
added a commit
that referenced
this pull request
Feb 28, 2015
pibizza
pushed a commit
that referenced
this pull request
Feb 28, 2015
Renaming CACHE_DIR to match its value (PDB_CACHE_DIR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.