Skip to content

Declare multiple mysqli_ functions as impure #5481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 7 commits into from
Apr 17, 2026
Merged

Declare multiple mysqli_ functions as impure #5481

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
38f6006
Fix phpstan/phpstan#14473: false positive logicalOr.leftAlwaysTrue on…
phpstan-bot Apr 15, 2026
55c63e4
Revert AssignHandler changes for bug #14473
phpstan-bot Apr 15, 2026
36db1ff
Mark mysqli_connect as having side effects in function metadata
phpstan-bot Apr 15, 2026
861bdde
Mark all side-effectful mysqli_ functions in function metadata
phpstan-bot Apr 15, 2026
00cce37
Mark all remaining mysqli_ functions as having side effects
phpstan-bot Apr 15, 2026
2abbe2e
Mark pure mysqli_ result-metadata functions as hasSideEffects=false
phpstan-bot Apr 15, 2026
17ec063
Remove redundant hasSideEffects=false entries for pure mysqli_ functions
phpstan-bot Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark mysqli_connect as having side effects in function metadata 
mysqli_connect establishes a network connection to a database server,
which is inherently a side effect. Marking it as hasSideEffects => true
causes TypeSpecifier to return empty SpecifiedTypes for the call, which
prevents stale conditional expressions from being created and fixes the
false positive logicalOr.leftAlwaysTrue on repeated calls.

Fixes phpstan/phpstan#14473

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude
phpstan-bot and claude committed Apr 15, 2026
commit 36db1ffe434fc74dcf6454813cbf79d3b2eb93cf
1 change: 1 addition & 0 deletions bin/functionMetadata_original.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
'link' => ['hasSideEffects' => true],
'mkdir' => ['hasSideEffects' => true],
'move_uploaded_file' => ['hasSideEffects' => true],
'mysqli_connect' => ['hasSideEffects' => true],
'ob_clean' => ['hasSideEffects' => true],
'ob_end_clean' => ['hasSideEffects' => true],
'ob_end_flush' => ['hasSideEffects' => true],
Expand Down
1 change: 1 addition & 0 deletions resources/functionMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,7 @@
'msgfmt_parse_message' => ['hasSideEffects' => false],
'mt_getrandmax' => ['hasSideEffects' => false],
'mt_rand' => ['hasSideEffects' => true],
'mysqli_connect' => ['hasSideEffects' => true],
'net_get_interfaces' => ['hasSideEffects' => false],
'ngettext' => ['hasSideEffects' => false],
'nl2br' => ['hasSideEffects' => false],
Expand Down
Loading