Add non regression test for 13043 - #4109
Merged
Merged
Conversation
Member
|
I'm thankful for the triage you did but please do not mention it in a non-related PR, instead post a comment in each issue. |
Member
|
Thank you! |
Contributor
Author
Ok. Do I need to ping you in each issue ? Or just commenting is enough for you to get a notification ? Also I assume I don't have to ping you for the ones already listed here (?) |
Member
|
I see all comments, even if they don't mention me. Yes, please say in each one of them that they can be closed, because when I close them the author will know why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13043
This was resolved when improving the array_map return type.
Also, I tried doing some triage and I think some issues which might be closed:
assign.propertyTypewith template phpstan#13080 is a valid error to me (as explained to the author)Dunno if it helps you (?)