Skip to content

WIP: Embedded Playground #4421

Open
f3l1x wants to merge 4 commits intophpstan:1.5.xfrom
f3l1x:feature/embed
Open

WIP: Embedded Playground #4421
f3l1x wants to merge 4 commits intophpstan:1.5.xfrom
f3l1x:feature/embed

Conversation

@f3l1x
Copy link
Copy Markdown
Contributor

@f3l1x f3l1x commented Jan 24, 2021

According to internal discussion, here is PR with embedded playground.

To-do:

  • Introduce /embed/ page
  • Playground support /embed/ page
  • Button to generate embed link /embed/r/hhhhaaaasssshhhh

Code:

<iframe src="https://phpstan.org/embed/r/hhhhaaaasssshhhh" sandbox="allow-same-origin allow-scripts" style="width: 100%; height: {HEIGHT}px; border: 0; border-radius: 4px; overflow: hidden;"></iframe>

Demo:

Screenshot 2021-01-24 at 16 23 29

Screenshot 2021-01-24 at 17 43 28

Copy link
Copy Markdown
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woar this looks awesome <3

@ondrejmirtes ondrejmirtes changed the base branch from master to 1.5.x March 12, 2022 12:25
m=f.getElementsByTagName('script')[0];
o.async=1; o.src=t; o.id='fathom-script';
m.parentNode.insertBefore(o,m)
})(document, window, 'https://cdn.usefathom.com/tracker.js', 'fathom');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What benefits does this tracker bring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants