TypeError dead catch when assigning mixed to int in property #9146

Activity

1. ondrejmirtes

   added

   bug

   on Apr 4, 2023
2. ondrejmirtes

   added this to the Easy fixes milestone on Apr 4, 2023
3. ondrejmirtes commented on Apr 4, 2023

   

   ondrejmirtes

   on Apr 4, 2023

   MemberAuthor

   More actions

   Related: phpstan/phpstan-src#1047
4. VincentLanglet commented on Apr 10, 2023

   

   VincentLanglet

   on Apr 10, 2023

   Contributor

   More actions

   It makes me think of #6232 @ondrejmirtes

   PHPStan should have consistency about exceptions about mixed.

   (string) $mixed is considered as not throwing an exception, the opposite would be annoying since it would force to add

   @throws Error
   

   above the function when using PHPStan with exceptions checks.
   It's recommended to add __toString or Stringable check rather than try catch the cast error

   Here, it's the same with $this->int = $mixed, it seems recommended to check is_int rather than try/catch.
5. phpstan-bot commented on Sep 4, 2024

   

   phpstan-bot

   on Sep 4, 2024

   Contributor

   More actions

   @ondrejmirtes After the latest push in 2.0.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -10: Dead catch - TypeError is never thrown in the try block.
   +PHP 8.0 – 8.2 (1 error)
   +==========
   +
   +10: Dead catch - TypeError is never thrown in the try block.
   +
   +PHP 7.2 – 7.4 (2 errors)
   +==========
   +
   + 6: Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   + 9: Property HelloWorld::$number (int) does not accept mixed.

   Full report

   PHP 8.0 – 8.2 (1 error)

   Line	Error
   10	Dead catch - TypeError is never thrown in the try block.

   PHP 7.2 – 7.4 (2 errors)

   Line	Error
   6	Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   9	Property HelloWorld::$number (int) does not accept mixed.
6. phpstan-bot commented on Dec 28, 2024

   

   phpstan-bot

   on Dec 28, 2024

   Contributor

   More actions

   @ondrejmirtes After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -10: Dead catch - TypeError is never thrown in the try block.
   +PHP 8.4
   +==========
   +
   +No errors
   +
   +PHP 8.0 – 8.3 (1 error)
   +==========
   +
   +10: Dead catch - TypeError is never thrown in the try block.
   +
   +PHP 7.2 – 7.4 (2 errors)
   +==========
   +
   + 6: Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   + 9: Property HelloWorld::$number (int) does not accept mixed.

   Full report

   PHP 8.4

   No errors

   PHP 8.0 – 8.3 (1 error)

   Line	Error
   10	Dead catch - TypeError is never thrown in the try block.

   PHP 7.2 – 7.4 (2 errors)

   Line	Error
   6	Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   9	Property HelloWorld::$number (int) does not accept mixed.
7. phpstan-bot commented on Nov 1, 2025

   

   phpstan-bot

   on Nov 1, 2025

   Contributor

   More actions

   @ondrejmirtes After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -10: Dead catch - TypeError is never thrown in the try block.
   +PHP 8.4 – 8.5
   +==========
   +
   +No errors
   +
   +PHP 8.0 – 8.3 (1 error)
   +==========
   +
   +10: Dead catch - TypeError is never thrown in the try block.
   +
   +PHP 7.2 – 7.4 (2 errors)
   +==========
   +
   + 6: Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   + 9: Property HelloWorld::$number (int) does not accept mixed.

   Full report

   PHP 8.4 – 8.5

   No errors

   PHP 8.0 – 8.3 (1 error)

   Line	Error
   10	Dead catch - TypeError is never thrown in the try block.

   PHP 7.2 – 7.4 (2 errors)

   Line	Error
   6	Parameter $number of method HelloWorld::__construct() has invalid type mixed.
   9	Property HelloWorld::$number (int) does not accept mixed.
8. ondrejmirtes commented on Nov 1, 2025

   

   ondrejmirtes

   on Nov 1, 2025

   MemberAuthor

   More actions

   There are no errors on PHP 8.4+ because of property hooks. The error would still show up for final classes/ final properties.
9. phpstan-bot

   added a commit that references this issue on Feb 16, 2026

   Fix TypeError dead catch false positive when assigning mixed to typed…

   ...

   45c195a
10. staabm commented on Feb 17, 2026

    

    staabm

    on Feb 17, 2026

    Last edited by staabm

    Contributor

    More actions

    the errors should depend on strict-types.

    e.g. int accepts a numeric-string with strict-types=0, but does not accept it with strict-types=1
    https://3v4l.org/2TIt2#veol
    https://3v4l.org/kVik8#veol

    int accepts float independent from strict-types (and vice versa)
11. phpstan-bot commented on Feb 18, 2026

    

    phpstan-bot

    on Feb 18, 2026

    Contributor

    More actions

    Closed via merging phpstan/phpstan-src#4981
12. phpstan-bot

    closed this as completedon Feb 18, 2026
13. github-actions commented on Mar 22, 2026

    

    github-actionsBot

    on Mar 22, 2026 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
14. github-actions

    locked as resolved and limited conversation to collaborators on Mar 22, 2026