Fix: Protect cluster session key from length overflow#2867
Merged
Conversation
Rework `cluster_session_key` to return either a newly allocated `zend_string*` when we have a prefix, or a cheap copy when we don't. Previously we were using `int` to curry the length which was in theory susceptible to overflow if `ZSTR_LEN(prefix) + keylen > INT_MAX)`. Fixes #2866
3 tasks
yatsukhnenko
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework
cluster_session_keyto return either a newly allocatedzend_string*when we have a prefix, or a cheap copy when we don't.Previously we were using
intto curry the length which was in theory susceptible to overflow ifZSTR_LEN(prefix) + keylen > INT_MAX).Fixes #2866