perf: Avoid zero-fill in redis_key_prefix#2853
Merged
michael-grunder merged 1 commit intoJun 2, 2026
Merged
Conversation
redis_key_prefix used ecalloc to allocate the prefixed-key buffer, then immediately overwrote the entire allocation with two memcpy calls. The zero-fill was wasted work on every keyed argument when a prefix is set. Use emalloc and write the single trailing NUL explicitly.
michael-grunder
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redis_key_prefixallocated the prefixed-key buffer withecalloc, then overwrote the whole allocation with twomemcpycalls. The zero-fill is wasted on every keyed argument when a prefix is set.Switch to
emallocand write the single trailing NUL explicitly.Built on PHP 8.4;
testPrefixpasses and a smoke test confirms the prefix is still applied on the wire.