Fix PHP 8.6 macro compatibility#2831
Open
arshidkv12 wants to merge 6 commits into
Open
Conversation
| object_properties_init(&cluster->std, class_type); | ||
| memcpy(&RedisCluster_handlers, zend_get_std_object_handlers(), sizeof(RedisCluster_handlers)); | ||
| RedisCluster_handlers.offset = XtOffsetOf(redisCluster, std); | ||
| RedisCluster_handlers.offset = offsetof(redisCluster, std); |
Member
There was a problem hiding this comment.
In PHP 7.4 there is still a bunch of #ifdef soup defending against offsetof not being defined.
In php >= 8.0 they stripped that out, so I'm guessing thisi is fine.
Contributor
Author
There was a problem hiding this comment.
Please check it https://github.com/krakjoe/apcu/pull/621/changes
Member
|
PR looks good. There are some PHP 7.4 compatibility errors though PHP 7.4 is quite EOL so I'll open an issue about dropping support sometime soon. For now we'll need to stay compatible. |
Contributor
Author
|
Sorry... I added code in my localhost. I will push it soon. Thank you |
Contributor
Author
|
Please check it |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php/php-src#20063
php/php-src#21146
arshidkv12/php-src@7114314