Skip to content

Fix issue with numeric strings as hash fields #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-grunder merged 1 commit into from
Jan 12, 2026
+7 −2
Merged

Fix issue with numeric strings as hash fields #2796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions redis_commands.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2944,14 +2944,19 @@ int redis_hincrbyfloat_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,
}

static inline zval *coerce_hash_field(zval *zv, zval *aux) {
char buf[32];
zend_long lv;
size_t len;

if (UNEXPECTED(Z_TYPE_P(zv) == IS_STRING &&
is_numeric_string(Z_STRVAL_P(zv),
Z_STRLEN_P(zv), &lv, NULL, 0) == IS_LONG))
{
ZVAL_LONG(aux, lv);
return aux;
len = snprintf(buf, sizeof(buf), "%ld", lv);
if (len == Z_STRLEN_P(zv) && redis_strncmp(Z_STRVAL_P(zv), buf, len) == 0) {
ZVAL_LONG(aux, lv);
return aux;
}
}

return zv;
Expand Down
Loading