Skip to content

Add additional arguments for XADD from Redis 6.2.0 missed by #1894 #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjavad wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add additional arguments for XADD from Redis 6.2.0 missed by #1894 #2393

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b9f16e
Add additional arguments for XADD from Redis 6.2.0 missed by #1894
cjavad Sep 24, 2023
f542d39
Remove TODO
cjavad Sep 24, 2023
2934ea8
Update warning message
cjavad Sep 24, 2023
d9a4b4c
Merge branch 'develop' into xadd-new-args
cjavad Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update warning message
  • Loading branch information
@cjavad
cjavad committed Sep 24, 2023
commit 2934ea8800a80a2a15d82991575d2e77b4e28c2c
2 changes: 1 addition & 1 deletion redis_commands.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5263,7 +5263,7 @@ int redis_xadd_cmd(INTERNAL_FUNCTION_PARAMETERS, RedisSock *redis_sock,

if (threshold < 0) {
php_error_docref(NULL, E_WARNING,
"Invalid MAXLEN/MINID argument or approximate flag");
"Invalid threshold argument flag");
}

/* Calculate argc for XADD. It's a bit complex because we've got
Expand Down