Skip to content

Variadic CONFIG GET/SET#2192

Merged
michael-grunder merged 2 commits into
developfrom
issue.2068-config-multi-getset
Oct 19, 2022
Merged

Variadic CONFIG GET/SET#2192
michael-grunder merged 2 commits into
developfrom
issue.2068-config-multi-getset

Conversation

@michael-grunder
Copy link
Copy Markdown
Member

Redis 7.0.0 allows for getting and setting multiple config values as an atomic operation. In order to support this while maintaining backward compatibility, the CONFIG command is reworked to also accept an array of values or keys and values.

See: #2068

Comment thread redis_commands.c Fixed
@michael-grunder
Copy link
Copy Markdown
Member Author

@yatsukhnenko This one was somewhat annoying 😄

We have to support the current single-setting GET and SET while also now supporting an array of elements. My first thought was to extend the method to be variadic, but I think that's even more irritating so I just allow users to instead send an array.

Redis 7.0.0 allows for getting and setting multiple config values as an
atomic operation.  In order to support this while maintaining backward
compatibility, the CONFIG command is reworked to also accept an array of
values or keys and values.

See: #2068
@michael-grunder michael-grunder force-pushed the issue.2068-config-multi-getset branch from 37d3f3f to 0aec32c Compare October 17, 2022 22:21
@michael-grunder michael-grunder mentioned this pull request Oct 19, 2022
37 tasks
Comment thread library.c
Comment thread redis_commands.c Outdated
@yatsukhnenko yatsukhnenko self-requested a review October 19, 2022 06:21
@michael-grunder michael-grunder merged commit a176f58 into develop Oct 19, 2022
@michael-grunder michael-grunder deleted the issue.2068-config-multi-getset branch October 19, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants