Skip to content

LMPOP and ZMPOP commands#2165

Merged
michael-grunder merged 2 commits into
developfrom
lmpop-zmpop
Oct 8, 2022
Merged

LMPOP and ZMPOP commands#2165
michael-grunder merged 2 commits into
developfrom
lmpop-zmpop

Conversation

@michael-grunder
Copy link
Copy Markdown
Member

No description provided.

Comment thread redis_commands.c Fixed
@michael-grunder
Copy link
Copy Markdown
Member Author

@yatsukhnenko Do you think I should create a custom zmpop handler to zip keys and scores?

@yatsukhnenko
Copy link
Copy Markdown
Member

@michael-grunder since lmpop and zmpop return a two-element array I think it would be better to zip results

@michael-grunder michael-grunder force-pushed the lmpop-zmpop branch 2 times, most recently from 9d15b81 to eb7825e Compare October 3, 2022 05:14
@michael-grunder
Copy link
Copy Markdown
Member Author

I will fix the cluster handler tomorrow

@michael-grunder
Copy link
Copy Markdown
Member Author

@yatsukhnenko OK the overall logic is ready for review now.

Implement the new Redis 7.0.0 commands to pop multiple elements from one
or more lists/zsets.

Additionally, remove INTERNAL_FUNCTION_PARAMETERS from the
redis_sock_read_multibulk_reply_zval helper function as it wasn't
actually being used.
@michael-grunder michael-grunder merged commit 7d60aba into develop Oct 8, 2022
@michael-grunder michael-grunder deleted the lmpop-zmpop branch October 8, 2022 16:19
@michael-grunder michael-grunder mentioned this pull request Oct 12, 2022
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants