Fix hex string literal (x'...') parsing in CREATE TABLE DEFAULT values#650
Open
predictor2718 wants to merge 5 commits intophpmyadmin:5.11.xfrom
Open
Fix hex string literal (x'...') parsing in CREATE TABLE DEFAULT values#650predictor2718 wants to merge 5 commits intophpmyadmin:5.11.xfrom
predictor2718 wants to merge 5 commits intophpmyadmin:5.11.xfrom
Conversation
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.11.x #650 +/- ##
============================================
+ Coverage 96.92% 96.93% +0.01%
- Complexity 2316 2331 +15
============================================
Files 71 71
Lines 5110 5128 +18
============================================
+ Hits 4953 4971 +18
Misses 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x'...'hex string literals as two separate tokens (keywordx+ string'...'), producing invalid SQLx AS '...'on rebuildb'...'binary literals) torecognize
x'...'andX'...'as single hex string literal tokensFLAG_NUMBER_HEX_STRINGto prevent incorrecthexdec()conversion of the token valueFixes #649