Skip to content

Fix tyephint on SelectStatement::$expr#583

Merged
MauricioFauth merged 1 commit into
phpmyadmin:5.10.xfrom
niconoe-:fix/typehint-select-expr
Sep 19, 2024
Merged

Fix tyephint on SelectStatement::$expr#583
MauricioFauth merged 1 commit into
phpmyadmin:5.10.xfrom
niconoe-:fix/typehint-select-expr

Conversation

@niconoe-
Copy link
Copy Markdown
Contributor

If you try to parse a query like

SELECT CASE WHEN `VALUE` = 1 THEN `COLUMN_ONE` END;

you will see that SelectStatement::$expr is actually containing a CaseExpression and not an Expression.

@MauricioFauth MauricioFauth merged commit f46b2c8 into phpmyadmin:5.10.x Sep 19, 2024
@MauricioFauth MauricioFauth self-assigned this Sep 19, 2024
@MauricioFauth MauricioFauth added this to the 5.10.1 milestone Sep 19, 2024
@niconoe- niconoe- deleted the fix/typehint-select-expr branch September 20, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants