Skip to content

Support KEY order (ASC/DESC)#350

Merged
williamdes merged 2 commits into
phpmyadmin:QAfrom
williamdes:support-key-order
Aug 26, 2021
Merged

Support KEY order (ASC/DESC)#350
williamdes merged 2 commits into
phpmyadmin:QAfrom
williamdes:support-key-order

Conversation

@williamdes
Copy link
Copy Markdown
Member

Fixes: #296

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to the 4.7.3 milestone Aug 21, 2021
@williamdes williamdes self-assigned this Aug 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2021

Codecov Report

Merging #350 (70894e4) into QA (1eb7d53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                 QA     #350   +/-   ##
=========================================
  Coverage     99.80%   99.80%           
- Complexity     1921     1925    +4     
=========================================
  Files            63       63           
  Lines          4622     4632   +10     
=========================================
+ Hits           4613     4623   +10     
  Misses            9        9           
Impacted Files Coverage Δ
src/Components/Key.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb7d53...70894e4. Read the comment docs.

@williamdes
Copy link
Copy Markdown
Member Author

Hi @iifawzi
What do you think about this one ?

Copy link
Copy Markdown
Contributor

@iifawzi iifawzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very neat, nice to be added!

Comment thread src/Components/Key.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 97e90e7 into phpmyadmin:QA Aug 26, 2021
@williamdes williamdes deleted the support-key-order branch August 26, 2021 00:16
williamdes added a commit to phpmyadmin/phpmyadmin that referenced this pull request Aug 26, 2021
Ref: phpmyadmin/sql-parser#350 (this PR documents the real type)

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this pull request Apr 21, 2023
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants