Fix #339 - Fixing the issue of not handling the procedures's options#346
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## QA #346 +/- ##
=========================================
Coverage 99.80% 99.80%
Complexity 1916 1916
=========================================
Files 63 63
Lines 4604 4605 +1
=========================================
+ Hits 4595 4596 +1
Misses 9 9
Continue to review full report at Codecov.
|
Contributor
Author
|
I've made a fake integration with PMA, and all the tests passed too :') |
williamdes
reviewed
Aug 20, 2021
williamdes
reviewed
Aug 20, 2021
17377a8 to
91aad6f
Compare
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
91aad6f to
58f852a
Compare
williamdes
reviewed
Aug 20, 2021
| array('parser/parseAlterUser5'), | ||
| array('parser/parseAlterUser6'), | ||
| array('parser/parseAlterUser7'), | ||
| array('parser/parseAlterUser8'), |
Member
There was a problem hiding this comment.
Good catch, I forgot to let you know I had patched it in: 1acb64c
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, This PR should fix the issues relating to #339
The issue was in
sql-parser/src/Statements/CreateStatement.php
Lines 221 to 237 in 2d1efde
it had some wrong tokens, and wasn't have many, which was leading to break the for loop that parses the options tokens
sql-parser/src/Components/OptionsArray.php
Lines 126 to 129 in 2d1efde
I've fixed and added the correct options tokens as much as I could. Ref
Signed-off-by: Fawzi E. Abdulfattah iifawzie@gmail.com