Fix #342 - Adding the support of altering user options#345
Merged
Conversation
4e66de5 to
9e88376
Compare
Codecov Report
@@ Coverage Diff @@
## QA #345 +/- ##
=========================================
Coverage 99.80% 99.80%
- Complexity 1915 1916 +1
=========================================
Files 63 63
Lines 4602 4604 +2
=========================================
+ Hits 4593 4595 +2
Misses 9 9
Continue to review full report at Codecov.
|
williamdes
approved these changes
Aug 17, 2021
Member
williamdes
left a comment
There was a problem hiding this comment.
This looks good, to better understand I will cut out and merge into QA and master your newly added tests
williamdes
pushed a commit
that referenced
this pull request
Aug 17, 2021
Pull-request: #345 Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
williamdes
approved these changes
Aug 17, 2021
williamdes
reviewed
Aug 17, 2021
9e88376 to
15d8e9b
Compare
Signed-off-by: Fawzi E. Abdulfattah <iifawzie@gmail.com>
15d8e9b to
2eff24a
Compare
williamdes
reviewed
Aug 17, 2021
williamdes
added a commit
that referenced
this pull request
Aug 17, 2021
Pull-request: #345 Signed-off-by: William Desportes <williamdes@wdes.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR should add the support of altering user options, not all the options are included though, because I'm not aware of all of them, I've just introduced the base.
Fixes #342
Signed-off-by: Fawzi E. Abdulfattah iifawzie@gmail.com