Fix #20190 - Handle missing parser statement in getForeigners()#20316
Open
eyupcanakman wants to merge 1 commit into
Open
Fix #20190 - Handle missing parser statement in getForeigners()#20316eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
…rs() getForeigners() reads the first parsed statement of the SHOW CREATE TABLE output. Some tables leave the parser with an empty statements array, for example a binary(16) column with a binary DEFAULT value, so reading statements[0] raises "Undefined array key 0". Guard the access with "?? null", which the existing instanceof CreateStatement check already treats as no foreign keys. Signed-off-by: Eyüp Can Akman <eyupcanakman@gmail.com>
c983176 to
308a715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getForeigners()reads$parser->statements[0]after parsing theSHOW CREATE TABLEoutput, but the parser returns no statement for some tables, for example a binary column with a binary default value. That raisesUndefined array key 0. Theinstanceof CreateStatementcheck right after already handlesnull.Same pattern on master in
getForeignKeysData().Fixes #20190.