Skip to content

Fix #20007 - Update create-release.sh with file to be excluded#20250

Open
liviuconcioiu wants to merge 5 commits intophpmyadmin:masterfrom
liviuconcioiu:create-release
Open

Fix #20007 - Update create-release.sh with file to be excluded#20250
liviuconcioiu wants to merge 5 commits intophpmyadmin:masterfrom
liviuconcioiu:create-release

Conversation

@liviuconcioiu
Copy link
Copy Markdown
Contributor

@liviuconcioiu liviuconcioiu commented Mar 21, 2026

Description

Fixes #20007

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@liviuconcioiu
Update create-release.sh with file to be excluded
465fa64 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@liviuconcioiu
Fix
9dff458 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.46%. Comparing base (f3363a3) to head (9dff458).
⚠️ Report is 8220 commits behind head on master.

Additional details and impacted files 
@@              Coverage Diff              @@
##             master   #20250       +/-   ##
=============================================
+ Coverage     49.50%   63.46%   +13.95%     
+ Complexity    16854    16060      -794     
=============================================
  Files           607      676       +69     
  Lines         69655    59891     -9764     
=============================================
+ Hits          34486    38007     +3521     
+ Misses        35169    21884    -13285
Flag Coverage Δ
unit-7.3-ubuntu-latest ?
unit-7.4-ubuntu-latest ?
unit-8.1-ubuntu-latest ?
unit-8.2-ubuntu-latest 63.43% <ø> (+14.08%) ⬆️
unit-8.3-ubuntu-latest 63.45% <ø> (+14.11%) ⬆️
unit-8.4-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liviuconcioiu
Copy link
Copy Markdown
Contributor Author

liviuconcioiu commented Mar 21, 2026

Is there something wrong with the PR? I don't see them being removed:

https://github.com/phpmyadmin/phpmyadmin/actions/runs/23380153474/job/68018242644#step:12:77

@MauricioFauth
Copy link
Copy Markdown
Member

MauricioFauth commented Mar 23, 2026

Is there something wrong with the PR? I don't see them being removed:

I think this script uses the master branch instead of the PR code.

@williamdes Do you think there's a easy way to run create-release.sh with the PR code when the file is modified? Otherwise I don't it's worth running it in pull requests.

MauricioFauth
MauricioFauth reviewed Mar 25, 2026
View reviewed changes
@williamdes
Copy link
Copy Markdown
Member

williamdes commented Mar 25, 2026

@williamdes Do you think there's a easy way to run create-release.sh with the PR code when the file is modified? Otherwise I don't it's worth running it in pull requests.

yes it is already done, I am pretty sure

williamdes
williamdes reviewed Mar 25, 2026
View reviewed changes
williamdes
williamdes reviewed Mar 25, 2026
View reviewed changes
liviuconcioiu and others added 3 commits April 6, 2026 21:19
@liviuconcioiu @MauricioFauth
Apply suggestion from @MauricioFauth
d96824b 
Co-authored-by: Maurício Meneghini Fauth <mauricio@mfauth.com.br>
@liviuconcioiu
Remove services.schema.json and keep schema folder
bcf11c0 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@liviuconcioiu
Move non-markdown files above
c2e27e1 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@liviuconcioiu
Copy link
Copy Markdown
Contributor Author

liviuconcioiu commented Apr 6, 2026 •
edited
Loading

I applied the changes, but the files aren't removed:

https://github.com/phpmyadmin/phpmyadmin/actions/runs/24047165958/job/70133342203#step:12:75

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 6, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@williamdes
Copy link
Copy Markdown
Member

williamdes commented Apr 7, 2026 •
edited
Loading

I applied the changes, but the files aren't removed:

https://github.com/phpmyadmin/phpmyadmin/actions/runs/24047165958/job/70133342203#step:12:75

Indeed, this is weird. Maybe it does not use the right branch

@williamdes
Copy link
Copy Markdown
Member

williamdes commented Apr 7, 2026

Yes that is it, the branch is hard coded. It should not run for PRs I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

@williamdes williamdes williamdes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[6.0]: Files to be excluded

4 participants

@liviuconcioiu @MauricioFauth @williamdes @phpmyadmin-bot