Force a full page reload for top menu links (5.2)#18675
Merged
Conversation
Each page is a different page, so it makes more sense to do a full page reload instead of using AJAX to load the main content. This also avoid some possible issues with broken event handlers and not properly loaded pages. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev> (cherry picked from commit 36a77f7) Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #18675 +/- ##
============================================
- Coverage 48.45% 47.71% -0.74%
Complexity 17012 17012
============================================
Files 607 607
Lines 72340 72340
============================================
- Hits 35052 34517 -535
- Misses 37288 37823 +535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back port of Force a full page reload for top menu links #18136
Fixes No database selected error after dropping a database #17404
Closes Fix #17404 - Handling and Redirecting to the database list page after dropping the current Database #17886