[ticket/17678] Let topic list pagination buttons grow with page number#6990
Open
ECYaz wants to merge 1 commit into
Open
[ticket/17678] Let topic list pagination buttons grow with page number#6990ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
The small pagination buttons next to multipage topics in the topic list had a fixed width sized for a single digit, so page numbers with two or more digits sat cramped against the button borders. Replace the fixed width with a minimum width so buttons keep their compact size for single digits but grow with the content, center the page number and size the button consistently via border box sizing. PHPBB-17678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17678
The small pagination buttons next to multipage topics in the topic list have a fixed width sized for a single digit, so page numbers with two or more digits sit cramped against the button borders, and three digit numbers wrap onto a second line and overflow the button.
This replaces the fixed width with a minimum width and border box sizing so the buttons keep their compact size for single digits but grow with the content, with the page number centered. Measured on prosilver: a single digit button stays 18px, a two digit button grows to 25px and a three digit button to 33px, all with even spacing around the number. The same block styles the topic list pagination in search results, the MCP forum view and the UCP topic lists, so those views are fixed as well. This follows the fix suggested in the ticket report.