Skip to content

Saving memories in operation processing #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m3m0r7 merged 11 commits into from
Apr 28, 2019
Merged

Saving memories in operation processing #102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ee29092
Saving memories in operation processing
m3m0r7 Apr 27, 2019
bb636ac
Disable trace
m3m0r7 Apr 28, 2019
fa7a67d
Fix refactoring missed
m3m0r7 Apr 28, 2019
1f74cbe
Update
m3m0r7 Apr 28, 2019
6f7a544
Versioning
m3m0r7 Apr 28, 2019
0d81009
Update tests
m3m0r7 Apr 28, 2019
f41a975
Fix constant pool
m3m0r7 Apr 28, 2019
e3894bf
Fix
m3m0r7 Apr 28, 2019
49dddc1
Fix
m3m0r7 Apr 28, 2019
9b91d44
Update
m3m0r7 Apr 28, 2019
d418be5
Fix
m3m0r7 Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix constant pool
  • Loading branch information
@m3m0r7
m3m0r7 committed Apr 28, 2019
commit f41a975c9a0e66cfe513f2d4fb0e22ed4184089c
6 changes: 3 additions & 3 deletions src/Core/JVM/Invoker/Invokable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,12 @@ function ($item) {
*/
$executor = OperationCache::fetchOrPush(
$fullName,
function () use ($fullName, &$currentConstantPool) {
return (new $fullName())
->setConstantPool($currentConstantPool);
function () use ($fullName) {
return new $fullName();
}
);
$returnValue = $executor
->setConstantPool($currentConstantPool)
->setParameters(
$method->getAttributes(),
$this->javaClassInvoker,
Expand Down
4 changes: 2 additions & 2 deletions src/Kernel/Core/Accumulator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function setParameters(
\PHPJava\Core\JVM\Stream\BinaryReader $reader,
array &$localStorage,
array &$stacks,
int &$pointer
int $pointer
): self {
$this->attributes = &$attributes;
$this->javaClassInvoker = &$javaClassInvoker;
Expand All @@ -46,7 +46,7 @@ public function setParameters(
$this->reader = &$reader;
$this->localStorage = &$localStorage;
$this->stacks = &$stacks;
$this->pointer = &$pointer;
$this->pointer = $pointer;
return $this;
}

Expand Down