Skip to content

Guarding against null values before unserializing #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brentscheffler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Guarding against null values before unserializing #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Guarding against null values before unserializing. This addresses E_D… 
…EPRECATED notices in PHP 8.2 when unserializing as it the function signature now only accepts string values.
  • Loading branch information
@brentscheffler
brentscheffler committed Oct 20, 2023
commit cddca5cfa3c87dbccb83c095bc99ee94a462206b
6 changes: 4 additions & 2 deletions src/Adapter/Predis/PredisCachePool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ public function __construct(Client $cache)
*/
protected function fetchObjectFromCache($key)
{
if (false === $result = unserialize($this->cache->get($this->getHierarchyKey($key)))) {
$result = $this->cache->get($this->getHierarchyKey($key));

if (false === $result || null === $result) {
return [false, null, [], null];
}

return $result;
return unserialize($result);
}

/**
Expand Down