Skip to content

CI fixes, Predis update, deprecation warning fix #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sideshowcoder wants to merge 5 commits into
base: master
Choose a base branch
from
Open

CI fixes, Predis update, deprecation warning fix #272

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8999079
Remove deprecation warning
sideshowcoder Feb 16, 2023
fd7e534
Update predis/predis
sideshowcoder Feb 16, 2023
098ed25
Update changelog
sideshowcoder Feb 16, 2023
6be5d78
Update ci workflow
sideshowcoder Mar 13, 2023
bc6f961
Fix composer-normalize workflow
sideshowcoder Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove deprecation warning 
`unserialize(null)` causes a deprecation warning flooding the logs, so in case
the cache for a given cache is empty this warning will be seen. To avoid this
use `''` as a replacement.

`unserialize(null) === unserialzie('') === false` this does not change behaviour.
  • Loading branch information
@sideshowcoder
sideshowcoder committed Mar 15, 2023
commit 8999079c23c91b50e8022b940281505f85cd8303
2 changes: 1 addition & 1 deletion src/Adapter/Predis/PredisCachePool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function __construct(Client $cache)
*/
protected function fetchObjectFromCache($key)
{
if (false === $result = unserialize($this->cache->get($this->getHierarchyKey($key)))) {
if (false === $result = unserialize($this->cache->get($this->getHierarchyKey($key)) ?? '')) {
return [false, null, [], null];
}

Expand Down