Skip to content

Update filesystem adapter to Flysystem v2 & v3#265

Open
Slamdunk wants to merge 3 commits into
php-cache:masterfrom
Slamdunk:flysystem_2n3
Open

Update filesystem adapter to Flysystem v2 & v3#265
Slamdunk wants to merge 3 commits into
php-cache:masterfrom
Slamdunk:flysystem_2n3

Conversation

@Slamdunk
Copy link
Copy Markdown

Question Answer
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets php-cache/issues#147
License MIT
Doc PR

Description

Supersedes #251 as @gijsdev seems inactive

TODO

  • Add tests
  • Add documentation
  • Updated Changelog.md

@prg-hussam
Copy link
Copy Markdown

Hello

when will this be ready ?

@thijsvdanker
Copy link
Copy Markdown

Anything I can do to move this forward?

@xvilo
Copy link
Copy Markdown

xvilo commented Nov 15, 2022

@Slamdunk whats the status of this? As this is (at least) the second MR. I am 🤏 close to just creating a new package that replaces this package until it's finished. Can you give us an update of the status? If there is a maintainer available for review, that would be wild (cc @Nyholm). A separate package for this implementation would make sense to me, while Flysystem is quite popular, it could be too specific to be included in here?

@Slamdunk
Copy link
Copy Markdown
Author

Slamdunk commented Nov 15, 2022

The PR is ready. We're just waiting for a maintainer's response

@oytuntez
Copy link
Copy Markdown

Maintainers don't seem to be responding to anything at all. Don't make us fork the whole php-cache ecosystem please...

@xvilo
Copy link
Copy Markdown

xvilo commented Aug 31, 2023

@Nyholm can you review and or accept this?

@igorsantos07
Copy link
Copy Markdown

igorsantos07 commented Jan 19, 2024

I wonder why they abandoned the package without officially tagging as abandoned, but still left a "migrate to Symfony" note on the README:

We created Symfony bundles and made many great libraries in the PHP-cache organization. This was a few years ago and the library is not activly maintained. Starting a new project one should consider using the more performant and activly supported Symfony Cache.

I guess, unless you need a bugfix, you can just add the PR's repo as a repository in your composer and move on with your Flysystem upgrade without having to migrate to non-abandoned-yet package 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants