Open pool for extension#225
Open
babesflorin wants to merge 4 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=========================================
Coverage 82.24% 82.24%
Complexity 615 615
=========================================
Files 33 33
Lines 1560 1560
=========================================
Hits 1283 1283
Misses 277 277
Continue to review full report at Codecov.
|
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I need to open the adapter for extension because I would like to override the methods that works with lists.
Real life scenario: I use Memcached as a cachePool and Redis as a tagStorePool. Right now when I append a key to a list it gets the list, appends the element to list and than saves the list. If I override appendListItem, removeListItem and use the native functionality of redis for working with lists it will be three times faster.