Skip to content

Added support for the Memcached getMulti setMulti and deleteMulti commands via the getMultiple setMultiple and deleteMultiple Cache methods#224

Open
detain wants to merge 22 commits into
php-cache:masterfrom
detain:master
Open

Conversation

@detain
Copy link
Copy Markdown

@detain detain commented Aug 13, 2018

Question Answer
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Description

Not sure if this is the best way to do this and the getMutliple method needs a bit of tweaking for the 1 assertion that fails.

TODO

  • Add tests
  • Add documentation
  • Updated Changelog.md

@prisis
Copy link
Copy Markdown
Contributor

prisis commented Aug 13, 2018

This class has all of this methods? take a look on https://github.com/php-cache/cache/blob/master/src/Adapter/Common/AbstractCachePool.php

@detain
Copy link
Copy Markdown
Author

detain commented Aug 13, 2018

yeah but they're not actually doing the Multi commands which uses hte memcached api to send/get/delete multiple keys at a time, instead of emulating the ability as it does without the patch. If I were to send an array with 10000 entries it would have made 10000 requests whereas with the Memcached built in Multi functions it can be cut down to a single request.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@202cd2b). Click here to learn what that means.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #224   +/-   ##
=========================================
  Coverage          ?   82.66%           
  Complexity        ?      645           
=========================================
  Files             ?       33           
  Lines             ?     1621           
  Branches          ?        0           
=========================================
  Hits              ?     1340           
  Misses            ?      281           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/Adapter/Memcached/MemcachedCachePool.php 94.73% <93.54%> (ø) 43 <29> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202cd2b...4e5593e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants