Handle PHP-bug with single char vars#205
Conversation
We encounter an issue with single-char PHP vars in production (running on amphp/aerys). We observe regularly, that single-char-vars become undefined. After PHP restart everything is ok again. The bug definitely exists in 7.1.9 + 7.1.11 Fixing that bug is hard, a workaround is simple and does not harm. Thanks!
|
Hey :) |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
Coverage 81.95% 81.95%
Complexity 598 598
=========================================
Files 31 31
Lines 1524 1524
=========================================
Hits 1249 1249
Misses 275 275
Continue to review full report at Codecov.
|
|
Most probably not, but it's one that affects us. Curiosly, our own code contains zillions of things like "Exception $e". We never observed logs from these but what happens on a regular basis is like Results in Yes, I am serious :( |
|
Can you add the 2 php version to travis? And can you please change than all of the places where something like this exists |
|
If you take a look on symfony code, they have many single-char names for functions And im not against it, to change the single-chars to a normal name |
|
@prisis Adding more php versions to travis won't prove anything unfortunately. We cannot reproduce that in a deterministic way. We observe that bug only in long running programs after an indefinite amount of time. Btw.: I opened a PHP issue for that https://bugs.php.net/bug.php?id=75710&thanks=4 |
|
On the top of my head, this is the only place we use a single char var like this. I’m also not sure of adding these PHP versions to Travis. Travis does not even support all patch versions. |
|
@Nyholm Then I'd be happy about a merge :) Actually it's not a big deal, right? |
|
Thank you. |
We encounter an issue with single-char PHP vars in production (running on amphp/aerys). We observe regularly, that single-char-vars become undefined. After PHP restart everything is ok again. The bug definitely exists in 7.1.9 + 7.1.11 Fixing that bug is hard, a workaround is simple and does not harm. Thanks!
We encounter an issue with single-char PHP vars in production (running on amphp/aerys). We observe regularly, that single-char-vars become undefined. After PHP restart everything is ok again. The bug definitely exists in 7.1.9 + 7.1.11
Fixing that bug is hard, a workaround is simple and does not harm.
Thanks!
Description
TODO