Repository navigation
Conversation
…ser comparison callback php_array_diff_key() and php_array_intersect_key() parse the callback straight into BG(user_compare_fci) without saving the previous value, unlike the other array_u*() functions. A comparison callback that calls one of them is replaced by the inner callback for the rest of the sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array_udiff_assoc()andarray_uintersect_assoc()parse the callback straight intoBG(user_compare_fci)and never restore the previous value, unlike the otherarray_u*()functions. A comparison callback that calls one of them is replaced by the inner callback for the rest of the sort.Split out of #24426, where the review pointed out these two functions.
To reproduce on PHP 8.4
Before:
outer inner inner inner(the outer comparator is replaced after the first call)After:
outer inner outer inner outer inner