Skip to content

Fix serialize() throwing for arrays that refer to themselves through references of refcount 1 #24446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lacatoire wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
Open

Fix serialize() throwing for arrays that refer to themselves through references of refcount 1 #24446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions ext/standard/tests/serialize/serialize_reference_cycle_refcount1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
--TEST--
serialize(): array referring to itself through references of refcount 1
--FILE--
<?php

function build() {
$parent = ['name' => 'parent'];
$child = ['name' => 'child'];
$child['parent'] = &$parent;
$parent['children'][] = &$child;
return $parent;
}

$serialized = serialize(build());
echo $serialized, "\n";
var_dump(unserialize($serialized)['children'][0]['parent']['children'][0]);

?>
--EXPECT--
a:2:{s:4:"name";s:6:"parent";s:8:"children";a:1:{i:0;a:2:{s:4:"name";s:5:"child";s:6:"parent";a:2:{s:4:"name";s:6:"parent";s:8:"children";a:1:{i:0;N;}}}}}
NULL
11 changes: 10 additions & 1 deletion ext/standard/var.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,16 +1018,25 @@ static void php_var_serialize_nested_data(smart_str *buf, zval *struc, HashTable
php_var_serialize_string(buf, ZSTR_VAL(key), ZSTR_LEN(key));
}

bool unwrapped_ref = false;
if (Z_ISREF_P(data) && Z_REFCOUNT_P(data) == 1) {
data = Z_REFVAL_P(data);
unwrapped_ref = true;
}

/* we should still add element even if it's not OK,
* since we already wrote the length of the array before */
if (Z_TYPE_P(data) == IS_ARRAY) {
if (UNEXPECTED(Z_TYPE_P(struc) == IS_ARRAY && Z_ARR_P(data) == Z_ARR_P(struc))) {
/* An array reached through a reference of refcount 1 is not recorded in
* var_hash, so a cycle made of such references has to be detected here. */
if (UNEXPECTED(Z_TYPE_P(struc) == IS_ARRAY && Z_ARR_P(data) == Z_ARR_P(struc))
|| (unwrapped_ref && UNEXPECTED(GC_IS_RECURSIVE(Z_ARR_P(data))))) {
php_add_var_hash(var_hash, struc, in_rcn_array);
smart_str_appendl(buf, "N;", 2);
} else if (unwrapped_ref) {
GC_TRY_PROTECT_RECURSION(Z_ARR_P(data));
php_var_serialize_intern(buf, data, var_hash, in_rcn_array, false);
GC_TRY_UNPROTECT_RECURSION(Z_ARR_P(data));
} else {
php_var_serialize_intern(buf, data, var_hash, in_rcn_array, false);
}
Expand Down
Loading