Skip to content

Fix glob() not negating bracket expressions that start with "^" #24422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-grekas wants to merge 2 commits into
base: PHP-8.5
Choose a base branch
from
+37 −0
Open

Fix glob() not negating bracket expressions that start with "^" #24422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b306b
Fix glob() not negating bracket expressions that start with "^"
nicolas-grekas Oct 19, 2026
284ccfd
Note that the leading '^' handling is not in OpenBSD's glob()
nicolas-grekas Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ext/standard/tests/file/glob_bracket_negation.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
--TEST--
glob() negates a bracket expression that starts with "!" or "^"
--FILE--
<?php
$dir = __DIR__ . '/glob_bracket_negation';
@mkdir($dir);
foreach (['a', 'b', 'c', '^', '!'] as $name) {
touch("$dir/$name");
}

foreach (['[!a]', '[^a]', '[!a-b]', '[^a-b]', '[!]a]', '[^]a]', '[a^]'] as $pattern) {
echo $pattern, ': ', implode(' ', array_map('basename', glob("$dir/$pattern"))), "\n";
}
?>
--CLEAN--
<?php
$dir = __DIR__ . '/glob_bracket_negation';
foreach (['a', 'b', 'c', '^', '!'] as $name) {
@unlink("$dir/$name");
}
@rmdir($dir);
?>
--EXPECT--
[!a]: ! ^ b c
[^a]: ! ^ b c
[!a-b]: ! ^ c
[^a-b]: ! ^ c
[!]a]: ! ^ b c
[^]a]: ! ^ b c
[a^]: ^ a
7 changes: 7 additions & 0 deletions main/php_glob.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@

#include "charclass.h"

#define CIRCUMFLEX '^'
#define DOLLAR '$'
#define DOT '.'
#define EOS '\0'
Expand Down Expand Up @@ -566,6 +567,12 @@ static int glob0(const Char *pattern, php_glob_t *pglob, struct glob_lim *limitp
switch (c) {
case LBRACKET:
c = *qpatnext;
/*
* Not in OpenBSD's glob(), keep it when syncing: like fnmatch(),
* treat a leading '^' as '!'.
*/
if (c == CIRCUMFLEX)
c = NOT;
if (c == NOT)
++qpatnext;
if (*qpatnext == EOS ||
Expand Down
Loading