Repository navigation
Conversation
During a request, opcache's interned-string handlers return a plain persistent string when the name is not already in shared memory. dl() registers a temporary module's function, class and property names this way, so under ZEND_RC_DEBUG the first refcount change on one of them (building an argument TypeError, ReflectionFunction::getName(), get_object_vars()) trips the persistent-string assertion. The strings belong to the request's temporary module; mark them GC_PERSISTENT_LOCAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly LINUX_X64_VARIATION_DEBUG_ZTS failures of
frameless_temporary_opcache.phptand, on 8.5+,frameless_temporary.phpt. Names that dl() registers during a request come back from opcache's interned-string handlers as plain persistent strings, so the first refcount change on one trips the ZEND_RC_DEBUG assertion. They belong to the request's temporary module, so they are now marked GC_PERSISTENT_LOCAL; release builds are unaffected.