Repository navigation
ext/intl: Remove redundant SKIPIF checks from intl tests - #24416
Open
LamentXU123 wants to merge 1 commit into
Open
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These SKIPIFs are hidding issues.
SpoofcheckerINTL_IDNA_VARIANT_UTS46Normalizer::FORM_KC_CFshould be registed and exist in all of our supported version of ICU. If they are not then we are in trouble and the tests should reflect that.The following code block shows that they are all registed without any conditions.
php-src/ext/intl/php_intl.c
Lines 222 to 223 in 73d069e
php-src/ext/intl/php_intl_arginfo.h
Line 1245 in 73d069e
php-src/ext/intl/normalizer/normalizer_arginfo.h
Lines 85 to 89 in 73d069e