Repository navigation
Conversation
I ran PHP's tests on FreeBSD 15.1, and these were failing: - ext/iconv/tests/bug52211.phpt: trigger the error with an incomplete UTF-8 source sequence. Rejecting a valid but unrepresentable character is implementation-defined; FreeBSD's ASCII passes bytes through for identity conversions, while glibc rejects them. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296765 - ext/standard/tests/file/chmod_basic.phpt: probe which special mode bits can be set on a regular file. FreeBSD rejects the sticky bit on regular files with EFTYPE. - ext/standard/tests/file/006_variation2.phpt: apply the sticky bit only to the directory, whose semantics are portable, and update the expected file modes. - ext/standard/tests/ini_info/php_ini_loaded_file.phpt: do not forward TEST_PHP_EXTRA_ARGS for the "no ini file" case. It can contain -c, which takes precedence over -n, causing the child to load run-tests.php's temporary ini file. Also clear the stat cache before calling fileperms(), not after.
Member
|
Tagging myself since I think this will help test failures on PASE (see GH-22837, been whittling those away), just need to get around to testing it (can't tonight). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran PHP's tests on FreeBSD 15.1, and these were failing:
ext/iconv/tests/bug52211.phpt: trigger the error with an incomplete UTF-8 source sequence. Rejecting a valid but unrepresentable character is implementation-defined; FreeBSD's ASCII passes bytes through for identity conversions, while glibc rejects them. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=296765
ext/standard/tests/file/chmod_basic.phpt: probe which special mode bits can be set on a regular file. FreeBSD rejects the sticky bit on regular files with EFTYPE.
ext/standard/tests/file/006_variation2.phpt: apply the sticky bit only to the directory, whose semantics are portable, and update the expected file modes.
ext/standard/tests/ini_info/php_ini_loaded_file.phpt: do not forward TEST_PHP_EXTRA_ARGS for the "no ini file" case. It can contain -c, which takes precedence over -n, causing the child to load run-tests.php's temporary ini file.
Also clear the stat cache before calling fileperms(), not after.