Repository navigation
Conversation
The original PR phpGH-16952 introduced special handling and a special flag to store the attribute via an OP_DATA opcode. It required special handling in various places. This commit reworks that by introducing a type specialization of the zend_constant structure and storing the attribute data in the main op array. This reduces complexity and removes special handling in various places.
Girgias
reviewed
Oct 18, 2026
Girgias
left a comment
Member
There was a problem hiding this comment.
I did an extremely cursory read and can't see anything obviously wrong, but then it's 3 AM after me going out, so you know.
Girgias
approved these changes
Oct 18, 2026
Girgias
left a comment
Member
There was a problem hiding this comment.
Had a better look and I can't see any problems and this is a nice simplification. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR GH-16952 introduced special handling and a special flag to store the attribute via an OP_DATA opcode. It required special handling in various places.
This commit reworks that by introducing a type specialization of the zend_constant structure and storing the attribute data in the main op array.
This reduces complexity and removes special handling in various places.