Keep compiled RuleBasedBreakIterator rules alive for the iterator - #23322
Open
iliaal wants to merge 1 commit into
Open
Keep compiled RuleBasedBreakIterator rules alive for the iterator#23322iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
LamentXU123
requested changes
Aug 16, 2026
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Again, should this target 8.4?
(Not looking at the code yet, just asking branch-wise)
The ICU compiled-rules constructor aliases the caller's buffer. PHP passed the argument string and did not retain it, so a later setText/next can use freed memory. Hold a zend_string copy on the object and release it in free_obj; clone addrefs it.
iliaal
force-pushed
the
fix/intl-rbbi-compiled-rules-lifetime
branch
from
August 16, 2026 16:48
6e871a7 to
7678a87
Compare
Contributor
Author
|
Yeah, 8.4 is needed here too |
devnexen
reviewed
Aug 16, 2026
| !!safe_reverse; | ||
| RULES; | ||
|
|
||
| $src = new IntlRuleBasedBreakIterator($rules); |
Member
There was a problem hiding this comment.
I think the fix is good enough, the test needs to truly trigger the case we re interested in. You need to force rules reclaims here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU's compiled-rules constructor aliases the caller buffer. PHP passed a temporary string and did not keep it, so setText/next after that string is released can use freed memory. The object now holds a zend_string copy, released in free_obj and addref'd on clone.